Skip to content

OCPBUGS-57824 added Known Issues section to cert-manager release notes #96128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

OCPBUGS-57824 added Known Issues section to cert-manager release notes #96128

wants to merge 1 commit into from
+5 −0

Conversation

wgabor0427
Copy link
Contributor

@wgabor0427 wgabor0427 commented Jul 15, 2025 •
edited
Loading

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 15, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Jul 15, 2025 •
edited
Loading

🤖 Wed Jul 16 16:01:21 - Prow CI generated the docs preview:

https://96128--ocpdocs-pr.netlify.app/openshift-enterprise/latest/security/cert_manager_operator/cert-manager-operator-release-notes.html

ocpdocs-vale-bot
ocpdocs-vale-bot reviewed Jul 15, 2025
View reviewed changes
security/cert_manager_operator/cert-manager-operator-release-notes.adoc Outdated
[id="cert-manager-operator-1-16-1-known-issues_{context}"]
=== Known Issues

When using the Venafi issuer with username/password authentication in cert-manager versions 1.16.0 and later, the default client ID is hardcoded as `cert-manager.io` and cannot be customized. This limitation can affect users requiring a specific client ID for authentication with the Venafi platform. Support for configurable client IDs will be introduced in cert-manager version 1.17.0.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 [error] RedHat.TermsErrors: Use 'hard-coded' rather than 'hardcoded'. For more information, see RedHat.TermsErrors.

lunarwhite
lunarwhite reviewed Jul 16, 2025
View reviewed changes
Copy link
Member

@lunarwhite lunarwhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to add this into 1.16.0 section (this place:

openshift-docs/security/cert_manager_operator/cert-manager-operator-release-notes.adoc

Line 80 in 7ec3458

security/cert_manager_operator/cert-manager-operator-release-notes.adoc Outdated
[id="cert-manager-operator-1-16-1-known-issues_{context}"]
=== Known Issues

When using the Venafi issuer with username/password authentication in cert-manager versions 1.16.0 and later, the default client ID is hard-coded as `cert-manager.io` and cannot be customized. This limitation can affect users requiring a specific client ID for authentication with the Venafi platform. Support for configurable client IDs will be introduced in cert-manager version 1.17.0.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
When using the Venafi issuer with username/password authentication in cert-manager versions 1.16.0 and later, the default client ID is hard-coded as `cert-manager.io` and cannot be customized. This limitation can affect users requiring a specific client ID for authentication with the Venafi platform. Support for configurable client IDs will be introduced in cert-manager version 1.17.0.
When using the Venafi issuer with username/password authentication in cert-manager version 1.16.0, the default client ID is hard-coded as `cert-manager.io` and cannot be customized. This limitation can affect users requiring a specific client ID for authentication with the Venafi platform. Support for configurable client IDs will be introduced in cert-manager version 1.17.0.

@lunarwhite
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 16, 2025
@wgabor0427
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Jul 16, 2025
@rh-tokeefe
Copy link
Contributor

/label peer-review-in-progress

@openshift-ci openshift-ci bot added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Jul 16, 2025
rh-tokeefe
rh-tokeefe reviewed Jul 16, 2025
View reviewed changes
security/cert_manager_operator/cert-manager-operator-release-notes.adoc
@@ -85,6 +85,11 @@ The peak memory use of the cert-manager components when they start up is optimiz
* link:https://access.redhat.com/security/cve/CVE-2024-45338[CVE-2024-45338]
* link:https://access.redhat.com/security/cve/CVE-2025-22866[CVE-2025-22866]

[id="cert-manager-operator-1-16-0-known-issues_{context}"]
=== Known Issues

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wgabor0427 I'm not familiar with this product or this section of the docs, so I'm just sharing some ideas and observations:

  • I would consider writing out "username and password authentication"
  • Typically, Red Hat refrains from pre-announcing features, bug fixes, etc. because in the past there have been incidents where a fix was announced but not delivered in the release mentioned. This can causes confustion for both customers and the Support organization, so I would remove the remove the reference to 1.17.0.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typically, Red Hat refrains from pre-announcing features, bug fixes, etc

@rh-tokeefe Thanks for pointing this out! This fix is merged and we could confirm 1.17.0 will contain this fix. In this situation, could we mention the version explicitly?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please ignore my comment. I'm fine with the latest change

@rh-tokeefe
Copy link
Contributor

@wgabor0427 a couple of minor suggestions I think you should consider before sending this on to merge review.

@rh-tokeefe
Copy link
Contributor

/label peer-review-done

@rh-tokeefe
Copy link
Contributor

/remove-label peer-review-in-progress

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Jul 16, 2025
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 16, 2025
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jul 16, 2025

@wgabor0427: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@lunarwhite
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lunarwhite lunarwhite lunarwhite left review comments

@rh-tokeefe rh-tokeefe rh-tokeefe left review comments

@ocpdocs-vale-bot ocpdocs-vale-bot ocpdocs-vale-bot left review comments

Assignees

@lunarwhite lunarwhite

Labels
lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR peer-review-needed Signifies that the peer review team needs to review this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@wgabor0427 @ocpdocs-previewbot @lunarwhite @rh-tokeefe @ocpdocs-vale-bot